Fixes scope validation failure in issue #8 - #9
Open
WASDDestroy wants to merge 4 commits into
Open
Conversation
…ad of using tricky preference read
we no longer needs this tricky method because LSPosed is capable to report module scope via libxposed service that binds on app launch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8. "The module currently displays a persistent 'wrong scope' error to users, even when the correct scope is selected."
Root Cause
The error stems from
ConfigIPCManager.java, which attempts to write the active scope to a shared preference via an IPC call. Directly accessing module's SharedPreference is not recommended in modern Xposed framework's hook callbacks and it will always fails.Solution
getScope()inModuleServiceBridge.java. Since the module declareslibxposed API 101, we can now reliably fetch the active scope list directly from the framework service, bypassing the unreliable preference-writing mechanism.statusOrdinal()inMainActivity.ktto iterate over the list returned bygetScope(), ensuring the UI accurately reflects whether the System Server is properly hooked.setModuleActive()and its call sites inMainHook.java. This method is redundant under API 101 (as the framework manages activation state).Testing Performed